[
https://issues.apache.org/jira/browse/FLINK-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044915#comment-15044915
]
ASF GitHub Bot commented on FLINK-3074:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1416#discussion_r46819640
--- Diff: flink-core/src/main/java/org/apache/flink/util/NetUtils.java ---
@@ -196,4 +198,35 @@ public static String hostAndPortToUrlString(String
host, int port) throws Unknow
}
return finalSet;
}
+
+ /**
+ * Tries to allocate a socket from the given sets of ports.
+ *
+ * @param portsSet A set of ports to choose from. The method will
remove the ports from the set!
+ * @param factory A factory for creating the SocketServer
+ * @param logger Logger instance
+ * @return null if no port was available or an allocated socket.
+ */
+ public static ServerSocket createSocketFromPorts(Set<Integer> portsSet,
SocketFactory factory, Logger logger) throws IOException {
--- End diff --
Why do you pass the logger as a parameter to the method? That way, it is
really hard to know from where the actual logging call was executed.
> Make ApplicationMaster/JobManager akka port configurable
> --------------------------------------------------------
>
> Key: FLINK-3074
> URL: https://issues.apache.org/jira/browse/FLINK-3074
> Project: Flink
> Issue Type: Improvement
> Components: YARN Client
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.0.0
>
>
> Similar to the BlobServer, the YARN ApplicationMaster should allow starting
> it on a specified list or range of ports.
> In cases where only certain ports are allowed by a firewall, users can
> specify a range of ports where they want the AM to allocate its RPC port
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
