[
https://issues.apache.org/jira/browse/FLINK-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiayi Liao updated FLINK-16753:
-------------------------------
Description:
If an exception is thrown when task is doing aysnc checkpoint, the checkpoint
will be declined and regarded as {{CheckpointFailureReason.JOB_FAILURE}}, which
gives a wrong message to users.
I think we can simply replace
{code:java}
owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
checkpointException);
{code}
with
{code:java}
owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
new CheckpointException(CheckpointFailureReason.EXCEPTION,
checkpointException));
{code}
in {{AsyncCheckpointRunnable.handleExecutionException}}.
cc [~trohrmann]
was:
If an exception is thrown when task is doing aysnc checkpoint, the checkpoint
will be declined and regarded as {{CheckpointFailureReason.JOB_FAILURE}}, which
gives a wrong message to users.
I think we can simply replace
{code:java}
owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
checkpointException);
{code}
with
{code:java}
owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
new CheckpointException(CheckpointFailureReason.EXCEPTION,
checkpointException));
{code}
cc [~trohrmann]
> Exception from AsyncCheckpointRunnable should be wrapped in
> CheckpointException
> -------------------------------------------------------------------------------
>
> Key: FLINK-16753
> URL: https://issues.apache.org/jira/browse/FLINK-16753
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
> Affects Versions: 1.10.0
> Reporter: Jiayi Liao
> Priority: Major
>
> If an exception is thrown when task is doing aysnc checkpoint, the checkpoint
> will be declined and regarded as {{CheckpointFailureReason.JOB_FAILURE}},
> which gives a wrong message to users.
> I think we can simply replace
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
> checkpointException);
> {code}
> with
>
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
> new CheckpointException(CheckpointFailureReason.EXCEPTION,
> checkpointException));
> {code}
> in {{AsyncCheckpointRunnable.handleExecutionException}}.
> cc [~trohrmann]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
