zentol commented on a change in pull request #10362: [FLINK-14792][coordination] Implement TE cluster partition release URL: https://github.com/apache/flink/pull/10362#discussion_r397685041
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ClusterPartitionHolder.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition; + +import org.apache.flink.runtime.jobgraph.IntermediateDataSetID; + +import java.util.Collection; + +/** + * Interface for components that can hold cluster partitions. + */ +public interface ClusterPartitionHolder { Review comment: The RM, or rather the component within the RM that interacts with the TE. The original idea was that we could pass the TEGateway to the PartitionTracker in the RM, providing access to the partitionRelease RPC without exposing the rest of the TEGateway. However, you may remember our recent discussion about providing access to the gateway to the tracker, and have opted for a different approach where the RM passes in a `ClusterPartitionHolder`, where the implementation calls the TEGateway method. https://github.com/apache/flink/pull/11443/commits/c5d34a31249ac85e5ce92903ee5d8d8da8dbb82d#diff-7c5af443934ab38b37031331cad9f8e3 So the interface should remain (albeit possibly moved into FLINK-14791 instead), but we'll need to extend the TEGateway in another way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
