[
https://issues.apache.org/jira/browse/FLINK-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066579#comment-17066579
]
Zhijiang commented on FLINK-16753:
----------------------------------
Thanks for the updates and I am clear now. I think it is reasonable to reuse
the existing `CheckpointException` to cover specific internal
`CheckpointFailureReason` instead of general `Exception` now.
I can assign this ticket to you if you are willing to contribute the PR. :)
> Exception from AsyncCheckpointRunnable should be wrapped in
> CheckpointException
> -------------------------------------------------------------------------------
>
> Key: FLINK-16753
> URL: https://issues.apache.org/jira/browse/FLINK-16753
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
> Affects Versions: 1.10.0
> Reporter: Jiayi Liao
> Priority: Major
>
> If an exception is thrown from task's async checkpoint process, the
> checkpoint will be declined as expected, but the reason for declining
> checkpoint will be regarded as {{CheckpointFailureReason.JOB_FAILURE}}, which
> gives a wrong message to users.
> I think we can simply replace
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
> checkpointException);
> {code}
> with
>
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
> new CheckpointException(CheckpointFailureReason.EXCEPTION,
> checkpointException));
> {code}
> in {{AsyncCheckpointRunnable.handleExecutionException}}.
> cc [~trohrmann]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
