[ 
https://issues.apache.org/jira/browse/FLINK-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044980#comment-15044980
 ] 

ASF GitHub Bot commented on FLINK-3112:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1436#issuecomment-162530467
  
    Good catch, @jaoki and thanks for making me aware of this @zentol.
    
    `Plan` was originally implemented for the Record API. For the later DataSet 
API, `JavaPlan` extends `Plan` and only overrides the `getPostPassClassName()` 
method. I checked the code and `Plan` is nowhere instantiated, only `JavaPlan`. 
    
    I will move the `getPostPassClassName()` from `JavaPlan` to `Plan` and 
remove `JavaPlan`.


> Remove unused RecordModelPostPass class
> ---------------------------------------
>
>                 Key: FLINK-3112
>                 URL: https://issues.apache.org/jira/browse/FLINK-3112
>             Project: Flink
>          Issue Type: Task
>          Components: Optimizer
>    Affects Versions: 1.0.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Trivial
>             Fix For: 1.0.0
>
>
> {{RecordModelPostPass.java}} belongs to the recently removed Record API and 
> should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to