dianfu commented on a change in pull request #11470: [FLINK-16671][python]
Support for defining scopes and variables on Python metric group
URL: https://github.com/apache/flink/pull/11470#discussion_r397888902
##########
File path:
flink-python/src/main/java/org/apache/flink/python/AbstractPythonFunctionRunner.java
##########
@@ -224,4 +235,15 @@ public JobBundleFactory createJobBundleFactory(Struct
pipelineOptions) throws Ex
public abstract ExecutableStage createExecutableStage() throws
Exception;
public abstract OutputReceiverFactory createOutputReceiverFactory();
+
+ /**
+ * Gets the proto representation of the base MetricGroup used for all
user-defined functions.
Review comment:
What about remove the `used for all user-defined functions` as metrics will
be used not only for UDF?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
