twalthr commented on a change in pull request #11280: [FLINK-16377][table] 
Support inline user defined functions in expression dsl
URL: https://github.com/apache/flink/pull/11280#discussion_r397919433
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/bridging/BridgingUtils.java
 ##########
 @@ -52,8 +52,15 @@
  * Utilities for bridging {@link FunctionDefinition} with Calcite's 
representation of functions.
  */
 final class BridgingUtils {
+       static String createName(FunctionIdentifier identifier, 
FunctionDefinition definition) {
 
 Review comment:
   nit: add `@Nullable` to all arguments in this util

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to