[ 
https://issues.apache.org/jira/browse/FLINK-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067304#comment-17067304
 ] 

Jark Wu commented on FLINK-14902:
---------------------------------

Hi [~phoenixjiangnan], sorray I still don't have enough time to go through this 
pull request. But we can discuss the approach here first. 

Regarding to [~hailong wang]'s proposal, 

1. HikariCP is licensed under Apache License v2, so I think it's legally. But I 
don't have experience on HikariCP. Did you investigate other connection 
management framework? And what's the adavantages and disadvantages of  HikariCP 
compared to other frameworks?

2. Fixed thread pool sounds good to me.

3. I would like to postpone batching queries to the future. 

4. Yes. We should have a cache. 

> JDBCTableSource support AsyncLookupFunction
> -------------------------------------------
>
>                 Key: FLINK-14902
>                 URL: https://issues.apache.org/jira/browse/FLINK-14902
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / JDBC
>    Affects Versions: 1.9.0
>            Reporter: hailong wang
>            Assignee: hailong wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> JDBCTableSource support AsyncLookupFunction



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to