JingsongLi commented on a change in pull request #11381: 
[FLINK-16294][connectors /jdbc]Support to create non-existed table in database 
automatically when writing data to JDBC connector.
URL: https://github.com/apache/flink/pull/11381#discussion_r398289059
 
 

 ##########
 File path: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialect.java
 ##########
 @@ -139,4 +146,46 @@ default String getSelectFromStatement(String tableName, 
String[] selectFields, S
                return "SELECT " + selectExpressions + " FROM " +
                                quoteIdentifier(tableName) + 
(conditionFields.length > 0 ? " WHERE " + fieldExpressions : "");
        }
+
+       /**
+        * Get create table statement.
+        */
+       default String getCreateTableStatement(String tableName, String[] 
fieldNames,
 
 Review comment:
   According flink code style: every parameter should be a single line if you 
want to break one line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to