TisonKun commented on a change in pull request #11460: [FLINK-16655][FLINK-16657] Introduce embedded executor and use it for Web Submission URL: https://github.com/apache/flink/pull/11460#discussion_r398298756
########## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutor.java ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.deployment.application.executors; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.JobID; +import org.apache.flink.api.dag.Pipeline; +import org.apache.flink.client.FlinkPipelineTranslationUtil; +import org.apache.flink.client.deployment.application.EmbeddedClient; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.ConfigUtils; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.CoreOptions; +import org.apache.flink.configuration.PipelineOptions; +import org.apache.flink.configuration.PipelineOptionsInternal; +import org.apache.flink.core.execution.JobClient; +import org.apache.flink.core.execution.PipelineExecutor; +import org.apache.flink.runtime.dispatcher.DispatcherGateway; +import org.apache.flink.runtime.jobgraph.JobGraph; +import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.net.MalformedURLException; +import java.net.URL; +import java.util.Collection; +import java.util.List; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; + +import static java.util.Objects.requireNonNull; + +/** + * A {@link PipelineExecutor} that is expected to be executed on the same machine as the + * {@link org.apache.flink.runtime.dispatcher.DispatcherGateway Dispatcher} and uses it directly + * to submit and monitor jobs. + */ +@Internal +public class EmbeddedExecutor implements PipelineExecutor { + + private static final Logger LOG = LoggerFactory.getLogger(EmbeddedExecutor.class); + + public static final String NAME = "Embedded"; + + private final Collection<JobID> applicationJobIds; + + private final DispatcherGateway dispatcherGateway; + + public EmbeddedExecutor( + final Collection<JobID> applicationJobIds, + final DispatcherGateway gateway) { + this.applicationJobIds = requireNonNull(applicationJobIds); + this.dispatcherGateway = requireNonNull(gateway); + } + + @Override + public CompletableFuture<JobClient> execute(final Pipeline pipeline, final Configuration configuration) { + requireNonNull(pipeline); + requireNonNull(configuration); + + final JobGraph jobGraph = getJobGraph(pipeline, configuration); + final JobID actualJobId = jobGraph.getJobID(); + + this.applicationJobIds.add(actualJobId); + LOG.info("Job {} is submitted.", actualJobId); + + final EmbeddedClient embeddedClient = new EmbeddedClient(actualJobId, configuration, dispatcherGateway); + return embeddedClient + .submitJob(jobGraph) + .thenApplyAsync(jobID -> embeddedClient); + } + + private JobGraph getJobGraph(final Pipeline pipeline, final Configuration configuration) { + final int parallelism = configuration.getInteger(CoreOptions.DEFAULT_PARALLELISM); + final List<URL> jars = decodeUrlList(configuration, PipelineOptions.JARS); + final List<URL> classpaths = decodeUrlList(configuration, PipelineOptions.CLASSPATHS); + final SavepointRestoreSettings savepointRestoreSettings = SavepointRestoreSettings.fromConfiguration(configuration); + + final JobGraph jobGraph = FlinkPipelineTranslationUtil.getJobGraph(pipeline, configuration, parallelism); + jobGraph.addJars(jars); + jobGraph.setClasspaths(classpaths); + jobGraph.setSavepointRestoreSettings(savepointRestoreSettings); + + getJobId(configuration).ifPresent(jobGraph::setJobID); + + return jobGraph; + } + + private List<URL> decodeUrlList(final Configuration configuration, final ConfigOption<List<String>> configOption) { Review comment: We already have a similar util `ExecutionConfigAccessor. decodeUrlList`. I think we can reduce duplicates. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
