rmetzger commented on a change in pull request #11314: [FLINK-16411][AZP] Use 
google mvn mirror globally
URL: https://github.com/apache/flink/pull/11314#discussion_r398408959
 
 

 ##########
 File path: tools/azure-pipelines/jobs-template.yml
 ##########
 @@ -160,14 +160,17 @@ jobs:
         echo "##vso[task.setvariable variable=PATH]$JAVA_HOME_11_X64/bin:$PATH"
       displayName: "Set to jdk11"
       condition: eq('${{parameters.jdk}}', 'jdk11')
-    - script: ./tools/travis/setup_maven.sh
+    - script: |
+        source ./tools/ci/maven-utils.sh
+        setup_maven
+        echo "##vso[task.setvariable variable=M2_HOME]$M2_HOME"
 
 Review comment:
   Okay, so how do we proceed here?
   
   In any case, I'll remove the `export PATH`.
   
   Option A) I move the maven setup to `run-nightly-tests.sh`, I would also 
move the file itself into the `ci/` directory and add a warning so that people 
don't run it on their machines.
   
   Option B) I move the maven setup to the azure controller
   
   Option C) We only remove the PATH export.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to