XuQianJin-Stars commented on a change in pull request #11186: 
[FLINK-16200][sql] Support JSON_EXISTS for blink planner
URL: https://github.com/apache/flink/pull/11186#discussion_r399003672
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
 ##########
 @@ -801,6 +801,20 @@ object FunctionGenerator {
       new MethodCallGen(
         BuiltInMethod.IS_JSON_SCALAR.method)))
 
+  addSqlFunctionMethod(
+    JSON_EXISTS,
+    Seq(CHAR, CHAR),
 
 Review comment:
   > According to SQL 2016 Standard:
   > 
   > ```
   > <JSON API common syntax> ::= <JSON context item> <comma> <JSON path 
specification> [ AS <JSON table path name> ] [ <JSON passing clause> ]
   > <JSON context item> ::= <JSON value expression>
   > <JSON path specification> ::= <character string literal>
   > ```
   > 
   > Second parameter can only be string literal, and in Flink, it's `CHAR` 
type.
   
   Thank you very much for your analysis, it has helped me a lot.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to