becketqin commented on a change in pull request #10487: [FLINK-15100][connector/source] Add a base implementation for SourceReader. URL: https://github.com/apache/flink/pull/10487#discussion_r399072562
########## File path: flink-core/src/main/java/org/apache/flink/util/ThrowableCatchingRunnable.java ########## @@ -0,0 +1,52 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +package org.apache.flink.util; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.function.Consumer; + +/** + * This class catches all the {@link Throwable Throwables} from the wrapped runnable. This class is + * useful when the wrapped runnable is submitted to an executor where the UncaughtExceptionHandler + * is not usable. + */ +public class ThrowableCatchingRunnable implements Runnable { + private static final Logger LOG = LoggerFactory.getLogger(ThrowableCatchingRunnable.class); + private final Consumer<Throwable> exceptionHandler; + private final Runnable runnable; + + public ThrowableCatchingRunnable( + Consumer<Throwable> exceptionHandler, + Runnable runnable) { + this.exceptionHandler = exceptionHandler; + this.runnable = runnable; + } + + @Override + public void run() { + try { + runnable.run(); + } catch (Throwable t) { + LOG.error("Received uncaught exception.", t); Review comment: Fair enough. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
