[
https://issues.apache.org/jira/browse/FLINK-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045198#comment-15045198
]
ASF GitHub Bot commented on FLINK-3102:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1437#discussion_r46841758
--- Diff:
flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionLeader.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.kafka.internals;
+
+import org.apache.kafka.common.Node;
+
+import java.io.Serializable;
+import java.util.List;
+
+/**
+ * Serializable Topic Partition info with leader Node information.
+ * This class is used at runtime.
+ *
+ * The leader information does not account for equality!
+ */
+public class KafkaTopicPartitionLeader extends KafkaTopicPartition
implements Serializable {
+
+ private static final long serialVersionUID = 9145855900303748582L;
+
+ private final int leaderId;
+ private int leaderPort;
+ private String leaderHost;
+
+ public KafkaTopicPartitionLeader(String topic, int partition, Node
leader) {
+ super(topic, partition);
+ if(leader == null) {
+ this.leaderId = -1;
+ } else {
+ this.leaderId = leader.id();
+ this.leaderPort = leader.port();
+ this.leaderHost = leader.host();
+ }
+ }
+
+
+ public Node getLeader() {
+ if(this.leaderId == -1) {
+ return null;
+ } else {
+ return new Node(leaderId, leaderHost, leaderPort);
+ }
+ }
+
+ public static Object toString(List<KafkaTopicPartitionLeader>
partitions) {
+ StringBuilder sb = new StringBuilder();
+ for(KafkaTopicPartitionLeader p: partitions) {
+
sb.append(p.getTopic()).append(":").append(p.getPartition()).append(", ");
+ }
+ return sb.toString();
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ return super.equals(o);
--- End diff --
This is ignoring the leader IDs. Seems wrong...
> Allow reading from multiple topics with one FlinkKafkaConsumer
> --------------------------------------------------------------
>
> Key: FLINK-3102
> URL: https://issues.apache.org/jira/browse/FLINK-3102
> Project: Flink
> Issue Type: New Feature
> Components: Kafka Connector
> Reporter: Robert Metzger
> Assignee: Robert Metzger
>
> Currently, a Kafka consumer allows to read from only one topic.
> For cases where multiple topics contain messages with the same schema, it is
> useful to allow to subscribe to many topics using one FlinkKafkaConsumer
> instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
