wuchong commented on a change in pull request #11493: [FLINK-16160][table-common] Support computed column, proctime and watermark in Schema descriptor URL: https://github.com/apache/flink/pull/11493#discussion_r399103395
########## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/descriptors/CustomConnectorDescriptor.java ########## @@ -16,18 +16,16 @@ * limitations under the License. */ -package org.apache.flink.table.descriptors.python; +package org.apache.flink.table.descriptors; -import org.apache.flink.annotation.Internal; -import org.apache.flink.table.descriptors.ConnectorDescriptor; -import org.apache.flink.table.descriptors.DescriptorProperties; +import org.apache.flink.annotation.PublicEvolving; import java.util.Map; /** * Describes a custom connector to an other system. */ -@Internal +@PublicEvolving Review comment: Why do we need to move this to api module? It was internal used only. I saw that it is only used for testing COLLECTION table. Could you introduce a `TestingCollection` descriptor in test packages for that? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
