pnowojski commented on a change in pull request #11529:
[FLINK-16806][operators] Add support for InputSelection to
MultipleInputStreamOperator
URL: https://github.com/apache/flink/pull/11529#discussion_r399332194
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/MultipleInputSelectionHandler.java
##########
@@ -112,7 +112,7 @@ int selectNextInputIndex(int lastReadInputIndex) {
}
boolean shouldSetAvailableForAnotherInput() {
- return availableInputsMask != allSelectedMask &&
inputSelection.areAllInputsSelected();
+ return (inputSelection.getInputMask() & allSelectedMask &
~availableInputsMask) != 0;
Review comment:
Unfortunately no. We would still need to do this action once per record
around here:
```
org.apache.flink.streaming.runtime.io.MultipleInputSelectionHandler#nextSelection
void nextSelection() {
if (inputSelector == null) {
inputSelection = InputSelection.ALL;
} else {
inputSelection = inputSelector.nextSelection();
}
}
```
? And I would doubt that saving one bit operation would be visible anywhere,
while as I wrote logically I think it's clearer to have this operation here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
