dianfu commented on a change in pull request #11543: [FLINK-16672][python]
Support Counter, Gauge, Meter, Distribution metric type for Python UDF
URL: https://github.com/apache/flink/pull/11543#discussion_r399312399
##########
File path: flink-python/pyflink/table/udf.py
##########
@@ -39,6 +39,9 @@ def __init__(self, base_metric_group):
self._base_metric_group = base_metric_group
def get_metric_group(self) -> MetricGroup:
+ if not self._base_metric_group._metric_enabled:
Review comment:
An alternative solution is set `_base_metric_group` as None when metrics is
not enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
