libenchao commented on a change in pull request #11482: [FLINK-16581][table]
Minibatch deduplication lack state TTL bug fix
URL: https://github.com/apache/flink/pull/11482#discussion_r399807546
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -144,6 +145,21 @@ public String toString() {
'}';
}
+ @Override
+ public boolean equals(Object o){
Review comment:
We don't need to add `equals` method for `StateTtlConfig`, if you want to
compare an instance with `StateTtlConfig.DISABLED`, you can just do it like
`stateTtlConfig == StateTtlConfig.DISABLED`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
