wangyang0918 commented on a change in pull request #11456: [FLINK-16602][k8s] 
Rework the internal/external Service
URL: https://github.com/apache/flink/pull/11456#discussion_r399913762
 
 

 ##########
 File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java
 ##########
 @@ -112,4 +113,8 @@ public String getEntrypointClass() {
        public KubernetesConfigOptions.ServiceExposedType 
getRestServiceExposedType() {
                return 
flinkConfig.get(KubernetesConfigOptions.REST_SERVICE_EXPOSED_TYPE);
        }
+
+       public boolean enableInternalService() {
 
 Review comment:
   nit: maybe `isInternalServiceEnabled` is better. Since we do not really 
enable the internal service here, we just check the state.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to