twalthr commented on a change in pull request #11340: [Flink 14338] Upgrade 
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r399995930
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
 ##########
 @@ -776,7 +776,8 @@ public SqlMonotonicity getMonotonicity(SqlOperatorBinding 
call) {
         * We need custom group auxiliary functions in order to support nested 
windows.
         */
        public static final SqlGroupedWindowFunction TUMBLE = new 
SqlGroupedWindowFunction(
-                       SqlKind.TUMBLE, null,
+                       // The TUMBLE group function was hard code to $TUMBLE 
in CALCITE-3382.
+                       "$TUMBLE", SqlKind.TUMBLE, null,
 
 Review comment:
   Only TUMBLE, what about the other functions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to