[
https://issues.apache.org/jira/browse/FLINK-16850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071082#comment-17071082
]
Piotr Nowojski commented on FLINK-16850:
----------------------------------------
I mostly agree with [~AHeise].
I've encountered the same issues before, but they were rare enough for me, that
I didn't want to add the overhead of managing release inside ` flink-benchmark`
repository. That was because of two reasons:
# In the end I was always able to deduce which commit to use from
`flink-benchmark` to match some incompatible version from `flink` master.
# As [~AHeise] pointed out, this wouldn't solve all of the problems. If there
is a braking change in the middle of flink release cycle, we would still have
some incompatibility, unless for every braking change we would create some
tag/branch.
On the other hand doing releases is some extra work.
Maybe a counter proposal. What about that every time we detect and fix
incompatibility inside the `flink-benchmark`, we create a tag in the
`flink-benchmark` repository, with the name set to the `flink`'s repository
hash of the last commit that it was compatible with? This would be cheap,
because if there is a braking change, we need to modify/touch the
`flink-benchmark` repository anyway, so creating extra tag will not require any
context switching?
> Make flink-benchmark align with different releases of Flink
> -----------------------------------------------------------
>
> Key: FLINK-16850
> URL: https://issues.apache.org/jira/browse/FLINK-16850
> Project: Flink
> Issue Type: Improvement
> Components: Benchmarks
> Affects Versions: 1.10.0
> Reporter: Yun Tang
> Priority: Major
>
> Currently, [flink-benchmark|https://github.com/dataArtisans/flink-benchmarks]
> does not have any releases to align with release branches of Flink. Just
> change the {{flink.version}} when executing benchmark is not enough as
> {{flink-benchmark}} always use the latset interfaces which might not existed
> in previous Flink versions. Take FLINK-15222 for example, this let
> {{flink-benchmark}} to use new version of interface which is only existed
> after Flink-1.11
> I think we could also let {{flink-benchmark}} to have releases or at least
> specific branch to align with releases of Flink.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
