zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400636648
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
##########
@@ -67,6 +68,13 @@
*/
boolean addBufferConsumer(BufferConsumer bufferConsumer, int
subpartitionIndex) throws IOException;
+ default void addPriorityEvent(
+ AbstractEvent event,
+ int subpartitionIndex,
+ BufferConsumer eventBufferConsumer) throws IOException {
+ getSubpartition(subpartitionIndex).priorityEvent(event,
eventBufferConsumer);
Review comment:
We create another path for handling priority event, which might be
inconsistent with previous handling.
In normal `ResultPartition#addBufferConsumer`, we would also check the
`checkInProduceState` before adding into subpartition. Now we bypass this
process which might bring trouble for code maintenance.
Are there any blockers for reuse the previous code path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
