[
https://issues.apache.org/jira/browse/FLINK-16874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071479#comment-17071479
]
Xintong Song commented on FLINK-16874:
--------------------------------------
Thanks for reporting this issue, [~karmagyz].
I would not consider this as a bug, because the memory configurations are read
before {{TaskManagerRunner}} is launched. However, I agree with you that it
would be good to support memory configurations with dynamic properties for
standalone clusters. IIUC, this does not require changes. The only thing we
need to do is to forward the user arguments to {{BashJavaUtils}}.
> Respect the dynamic options when calculating memory options in taskmanager.sh
> -----------------------------------------------------------------------------
>
> Key: FLINK-16874
> URL: https://issues.apache.org/jira/browse/FLINK-16874
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Yangze Guo
> Priority: Major
> Fix For: 1.10.1, 1.11.0
>
>
> Since FLINK-9821, the taskmanager.sh will pass user-defined dynamic options
> to the TaskManagerRunner. However, in FLINK-13983, we calculate the
> memory-related configuration only according to the FLINK_CONF_DIR. We then
> append the calculation result as dynamic options to the TM, the user-defined
> dynamic options would be overridden and ignored.
> The BashJavaUtils is already support loading dynamic options, we just need to
> pass it in bash script.
> cc [~xintongsong] [~azagrebin]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
