godfreyhe commented on a change in pull request #11376: [FLINK-16535] [table]
BatchTableSink#emitDataSet returns DataSink
URL: https://github.com/apache/flink/pull/11376#discussion_r400705789
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/BatchTableSink.java
##########
@@ -31,5 +32,5 @@
public interface BatchTableSink<T> extends TableSink<T> {
/** Emits the DataSet. */
- void emitDataSet(DataSet<T> dataSet);
+ DataSink<?> emitDataSet(DataSet<T> dataSet);
Review comment:
> `consumeDataSet`?
agree, although the change is a little larger. `consumeDataSet` aligns with
`consumeDataStream`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
