rkhachatryan commented on a change in pull request #11534:
[FLINK-16537][network] Implement ResultPartition state recovery for unaligned
checkpoint
URL: https://github.com/apache/flink/pull/11534#discussion_r400753883
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -89,6 +91,25 @@
super(index, parent);
}
+ @Override
+ public void initializeState() throws IOException, InterruptedException {
+ ReadResult readResult = ReadResult.HAS_MORE_DATA;
+ while (readResult == ReadResult.HAS_MORE_DATA) {
+ BufferBuilder bufferBuilder =
parent.getBufferPool().requestBufferBuilderBlocking();
+ BufferConsumer bufferConsumer =
bufferBuilder.createBufferConsumer();
+ readResult =
parent.getChannelStateReader().readOutputData(subpartitionInfo, bufferBuilder);
Review comment:
> But your comment makes me think of another possible option, to pass
ChannelStateReader into ResultPartitionWriter#initializeState, then we do not
need to pass it into constructor to touch many components.
This is exactly what I meant by
> Why not to pass ChannelStateReader as a parameter to initializeState then?
So, instead of having `channelStateReader` field anywhere I'd pass it from
`StreamTask`
to `ResultPartitionWriter.initializeState()`
to `ResultPartition.initializeState()`
to `ResultSubpartition.initializeState()`
Sorry for the confusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
