zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400777298
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -184,17 +184,18 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
}
@Override
- public Collection<ResultPartition> createResultPartitionWriters(
Review comment:
I think we do not really need this commit change for guaranteeing the
consistent info during recovery. There should be no order concerns inside the
collection, and we only need to guarantee that the generated `ResultPartition`
and `SingleInputGate` inside the collection has always consistent infos as
before. And this guarantee has already been realized by making
`ResultPartitionDeploymentDescriptor` as list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
