[ 
https://issues.apache.org/jira/browse/FLINK-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071636#comment-17071636
 ] 

Chesnay Schepler commented on FLINK-16883:
------------------------------------------

hmm..I get the idea, but I'm wondering if the proposal as is isn't too 
powerful, since it allows the file to be in an arbitrary directory. The 
knowledge that the config file is under conf is quite neat and may be used in a 
future JIRA for modifying the file at runtime via the REST API.

I'm wondering whether the root problem is that we hard-code the exact file 
names. If we would search for `log4j-console.*` instead this would be 
_sufficient_, although you would have to ensure that there is only one such 
file in there. Which maybe isn't even a bad requirement since you would know 
which file was used, without having to go through the logs.

> No support for log4j2 configuration formats besides properties
> --------------------------------------------------------------
>
>                 Key: FLINK-16883
>                 URL: https://issues.apache.org/jira/browse/FLINK-16883
>             Project: Flink
>          Issue Type: Improvement
>          Components: Command Line Client
>    Affects Versions: 1.11.0
>            Reporter: Fabian Paul
>            Priority: Major
>
> If `flink.console.sh` is used to start a Flink cluster the env java opts 
> precede the log settings.  
> ([link|https://github.com/apache/flink/blob/master/flink-dist/src/main/flink-bin/bin/flink-console.sh#L73])
> This way the log settings `log4.configurationFile` will always overwrite 
> previous keys. Since the `log4j.configurationFile` is set to 
> `log4j.properties`, it is not possible to leverage other formats than 
> properties for the configuration.
>  
> My proposal would be to switch the order of the configurations that the log 
> settings precede the env java opts. Users could then overwrite the default 
> file with their configurations.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to