zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic 
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400827561
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
 ##########
 @@ -107,6 +107,20 @@
                return availabilityHelper.getAvailableFuture();
        }
 
+       /**
+        * Returns the index of this gate in respect to the consuming operator 
instance.
+        */
+       public int getGateIndex() {
+               throw new UnsupportedOperationException();
 
 Review comment:
   Are there any benefits for implementing unsupported way in default?
   If all the normal subclasses should implement it, it is better to define as 
abstract, otherwise the new added subclasses would not be aware of this method 
and cause unexpected exceptions in practice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to