[
https://issues.apache.org/jira/browse/FLINK-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047255#comment-15047255
]
Nick Dimiduk commented on FLINK-3147:
-------------------------------------
Looks like we should open up all the instance variables as protected as well.
At least everything that's not already exposed via accessor methods. What's the
preferred style: add protected accessor methods or mark the fields protected?
> HadoopOutputFormatBase should expose mutexes for subclasses
> -----------------------------------------------------------
>
> Key: FLINK-3147
> URL: https://issues.apache.org/jira/browse/FLINK-3147
> Project: Flink
> Issue Type: Improvement
> Reporter: Nick Dimiduk
> Priority: Minor
>
> While adopting PhoenixOutputFormat to a streaming job, I find that the
> implementation of {{HadoopOutputFormatBase#close}} is not relevant when
> there's no temp file to move. However, subclasses cannot effectively override
> implementation because {{CLOSE_MUTEX}} is marked private.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
