[
https://issues.apache.org/jira/browse/FLINK-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047812#comment-15047812
]
ASF GitHub Bot commented on FLINK-3147:
---------------------------------------
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-163074809
+1
LGTM
> HadoopOutputFormatBase should expose fields as protected
> --------------------------------------------------------
>
> Key: FLINK-3147
> URL: https://issues.apache.org/jira/browse/FLINK-3147
> Project: Flink
> Issue Type: Improvement
> Reporter: Nick Dimiduk
> Priority: Minor
>
> While adopting PhoenixOutputFormat to a streaming job, I find that the
> implementation of {{HadoopOutputFormatBase#close}} is not relevant when
> there's no temp file to move. However, subclasses cannot effectively override
> implementation because {{CLOSE_MUTEX}} is marked private.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
