zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r401423000
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -914,6 +914,11 @@ private void closeNetworkResources() {
LOG.error("Failed to release input gate for
task {}.", taskNameWithSubtask, t);
}
}
+ try {
+ taskStateManager.close();
Review comment:
The precious consideration of closing network resources early is done by
canceler thread, which would throw exception while task thread interacts with
buffer operation to make task exit ASAP. If we add the state manager close
here, does it have the same effect to throw any exceptions while interacting
with task thread?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
