nielsbasjes opened a new pull request #11592: [WIP]  [FLINK-16871][runtime] 
Make more build time information available at runtime
URL: https://github.com/apache/flink/pull/11592
 
 
   # [FLINK-16871](https://issues.apache.org/jira/browse/FLINK-16871): Make 
more build time information available at runtime
   
   ## What is the purpose of the change
   
   As discussed [here](https://github.com/apache/flink/pull/11245) additional 
build time information is needed at runtime. This pull request is to make this 
specific change a separate thing.
   
   ## Brief change log
   
     - Generate a Version.java file from maven with several properties.
     - Update the git-commit-id-plugin to the latest version (only the 
mentioned 2.1.14 was problematic). And updated the url in the comment to the 
git-commit-id-plugin github repo.
     - By fixating the datetime format in the git-commit-id-plugin these can be 
reliably exposed as returning an `Instant`. This makes it possible to reliably 
format these timestamps in any form we like. The code has been structured in 
such a way that as little as possible memory remains allocated.
     - The .version.properties is no longer generated as this was part of the 
old solution and it is not used anywhere else in the code base.
   
   
   ## Verifying this change
   
   This change added a few basic test steps.
   
   Verifying the actual values is not possible because after commit and on each 
build the values will (and should) be different. Also checking if the commit 
time is not older than X would mean that a working version of the software 
would fail the build a while later.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **yes: build time 
plugin is updated**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no, not really** A few 
more getters are now available in the EnvironmentInformation which only affects 
developers who need this information.
     - If yes, how is the feature documented? **JavaDocs**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to