Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1416#discussion_r47073443
  
    --- Diff: 
flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMasterBase.scala ---
    @@ -120,18 +125,76 @@ abstract class ApplicationMasterBase {
             config.setInteger(ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, 0)
           }
     
    -      val (actorSystem, jmActor, archiveActor, webMonitor) =
    +      // we try to start the JobManager actor system using the port 
definition
    +      // from the config.
    +      // first, we check if the port is available by opening a socket
    +      // if the actor system fails to start on the port, we try further
    +      val amPortRange: String = 
config.getString(ConfigConstants.YARN_APPLICATION_MASTER_PORT,
    +        ConfigConstants.DEFAULT_YARN_APPLICATION_MASTER_PORT)
    +      val portsIterator = NetUtils.getPortRangeFromString(amPortRange)
    +
    +      // method to start the actor system.
    +      def startActorSystem(portsIterator: java.util.Iterator[Integer]): // 
return type -> next line
    +        (ActorSystem, ActorRef, ActorRef, Option[WebMonitor]) = {
    +        val availableSocket = NetUtils.createSocketFromPorts(portsIterator,
    --- End diff --
    
    `portsIterator` should be in a separate line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to