rkhachatryan commented on a change in pull request #11515: [FLINK-16744][task] 
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r401879137
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
 ##########
 @@ -65,6 +75,8 @@ public void checkpointState(
                        CheckpointMetrics checkpointMetrics,
                        OperatorChain<?, ?> operatorChain,
                        Supplier<Boolean> isCanceled) throws Exception {
+               checkNotNull(checkpointOptions);
 
 Review comment:
   Both of these fields are unreferenced a few lines below. Do you think it 
makes sense to add this check at the beginning too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to