jinglining commented on a change in pull request #11542: [FLINK-16303][rest] Enable retrieval of custom JobManager log files URL: https://github.com/apache/flink/pull/11542#discussion_r402037069
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java ########## @@ -675,26 +704,6 @@ public WebMonitorEndpoint( return handlers; } - @Nonnull - private ChannelInboundHandler createStaticFileHandler( - Time timeout, - File fileToServe) { - - if (fileToServe == null) { - return new ConstantTextHandler("(file unavailable)"); Review comment: If it works, we could delete ConstantTextHandler. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services