klion26 opened a new pull request #11614: [FLINK-16916][serialization] Fix the logic of NullableSerializer#copy URL: https://github.com/apache/flink/pull/11614 ## What is the purpose of the change Fix the wrong logic of `NullableSerializer#copy`, currently, the logic is such as below: ``` public void copy(DataInputView source, DataOutputView target) throws IOException { boolean isNull = source.readBoolean(); target.writeBoolean(isNull); if (isNull) { target.write(padding); } else { originalSerializer.copy(source, target); } } ``` we forgot to skip paddings.length bytes when if the padding's length is not 0. We can correct the logic such as below ``` public void copy(DataInputView source, DataOutputView target) throws IOException { boolean isNull = deserializeNull(source); // this will skip the padding values. target.writeBoolean(isNull); if (isNull) { target.write(padding); } else { originalSerializer.copy(source, target); } } ``` ## Verifying this change Harden the test of `NullalbeSerialierTest#testSerializedCopyAsSequence` by update the test data. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (yes) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
