godfreyhe commented on a change in pull request #11276:
[FLINK-16029][table-planner-blink] Remove register source and sink in test
cases of blink planner
URL: https://github.com/apache/flink/pull/11276#discussion_r402243852
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/utils/InMemoryLookupableTableSource.scala
##########
@@ -42,11 +47,12 @@ import scala.collection.mutable
* A [[LookupableTableSource]] which stores table in memory, this is mainly
used for testing.
*/
class InMemoryLookupableTableSource(
- fieldNames: Array[String],
- fieldTypes: Array[TypeInformation[_]],
+ schema: TableSchema,
data: List[Row],
- asyncEnabled: Boolean)
- extends LookupableTableSource[Row] {
+ asyncEnabled: Boolean,
+ bounded: Boolean = false)
+ extends LookupableTableSource[Row]
+ with StreamTableSource[Row] {
Review comment:
Why we need to extend `StreamTableSource`, I don't see any new cases
introduced
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
