azagrebin commented on a change in pull request #11427: [FLINK-15790][k8s] Make
FlinkKubeClient and its implementations asynchronous
URL: https://github.com/apache/flink/pull/11427#discussion_r401749526
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -85,18 +87,18 @@ public String getClusterDescription() {
return () -> {
final Configuration configuration = new
Configuration(flinkConfig);
- final Endpoint restEndpoint =
client.getRestEndpoint(clusterId);
+ try {
+ final Optional<Endpoint> restEndpoint =
client.getRestEndpoint(clusterId).get();
Review comment:
when we do `future.get`, it will wrap any underlying exception into a
`ExecutionException`.
we usually call `ExceptionUtils#stripExecutionException` to unwrap it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
