[
https://issues.apache.org/jira/browse/FLINK-16666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074063#comment-17074063
]
Aljoscha Krettek commented on FLINK-16666:
------------------------------------------
I still think it's not the right approach to mix in the Python concerns in all
the other modules. (I also think it's not optimal that {{flink-clients}} now
also has Python-related code, this makes some things more complicated than they
need to be).
Ideally, both the Table API and SQL client don't use the environments from the
other APIs, so in the long run there needs to be a proper solution for this
anyways. Regarding the solution: I think it's also problematic that the code
mutates the Configuration, i.e. puts in new fields based on existing fields.
This makes the code more fragile and/or harder to debug.
I think either the generic {{TableEnvironment(Impl)}} or the planners are the
place to put the Python support code. For code sharing, maybe it's good to add
a module {{flink-python-core}} or {{flink-python-common}} to isolate those
common concerns.
> Support new Python dependency configuration options in flink-java,
> flink-streaming-java and flink-table
> -------------------------------------------------------------------------------------------------------
>
> Key: FLINK-16666
> URL: https://issues.apache.org/jira/browse/FLINK-16666
> Project: Flink
> Issue Type: Sub-task
> Components: API / Python
> Reporter: Wei Zhong
> Assignee: Wei Zhong
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
