xintongsong commented on a change in pull request #11615: [FLINK-16605] Add max
limitation to the total number of slots
URL: https://github.com/apache/flink/pull/11615#discussion_r402719726
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -131,13 +134,15 @@ public SlotManagerImpl(
Time taskManagerRequestTimeout,
Time slotRequestTimeout,
Time taskManagerTimeout,
+ int maxSlotNum,
boolean waitResultConsumedBeforeRelease) {
this.slotMatchingStrategy =
Preconditions.checkNotNull(slotMatchingStrategy);
this.scheduledExecutor =
Preconditions.checkNotNull(scheduledExecutor);
this.taskManagerRequestTimeout =
Preconditions.checkNotNull(taskManagerRequestTimeout);
this.slotRequestTimeout =
Preconditions.checkNotNull(slotRequestTimeout);
this.taskManagerTimeout =
Preconditions.checkNotNull(taskManagerTimeout);
+ this.maxSlotNum = maxSlotNum;
Review comment:
We should have a sanity check here to make sure `maxSlotNum > 0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
