kl0u commented on a change in pull request #11460: [FLINK-16655][FLINK-16657] Introduce embedded executor and use it for Web Submission URL: https://github.com/apache/flink/pull/11460#discussion_r402961693
########## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutorServiceLoader.java ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.deployment.application.executors; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.JobID; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.core.execution.PipelineExecutorFactory; +import org.apache.flink.core.execution.PipelineExecutorServiceLoader; +import org.apache.flink.runtime.dispatcher.DispatcherGateway; + +import java.util.Collection; +import java.util.stream.Stream; + +import static java.util.Objects.requireNonNull; + +/** + * A {@link PipelineExecutorServiceLoader} that always returns an {@link EmbeddedExecutorFactory}. + * This is useful when running the user's main on the cluster. + */ +@Internal +public class EmbeddedExecutorServiceLoader implements PipelineExecutorServiceLoader { + + private final Collection<JobID> applicationJobIds; + + private final DispatcherGateway dispatcherGateway; + + + /** + * Creates a {@link EmbeddedExecutorServiceLoader}. + * + * @param applicationJobIds a list initialized with the recovered jobs (if any). This list is also going to be filled + * by the {@link EmbeddedExecutor} with the job ids of the new jobs that will be submitted. The + * list can later be used for monitoring the status of the submitted/recovered jobs. + * @param dispatcherGateway the dispatcher of the cluster which is going to be used to submit jobs. + */ + public EmbeddedExecutorServiceLoader( + final Collection<JobID> applicationJobIds, Review comment: What do you mean by "two-way communication"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
