pnowojski commented on a change in pull request #11541: [FLINK-15416][network]
add task manager netty client retry mechenism
URL: https://github.com/apache/flink/pull/11541#discussion_r403455029
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -130,6 +130,23 @@ public void run() {
}
}
+ @Test
+ public void testNettyClientConnectRetry() throws Exception {
+ NettyClient nettyClient = mock(NettyClient.class);
Review comment:
Yes I noticed that and probably implementing `ChannelFuture` is not worth
it, hence I suggested to use `NettyTestUtil`. It looks like you could just init
a server (`NettyTestUtil#initServer()`) and `NettyClient` from `#initClient()`
and you could use it directly, without a need to implement custom
`ChannelFuture`? You can check usages of `NettyTestUtil`, like for example
`NettyClientServerSslTest#testClientUntrustedCertificate`.
I might be missing something, but it looks like it could work quite easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
