rmetzger commented on a change in pull request #11630: [FLINK-16921][e2e]
Describe all resources and show pods logs before cleanup when failed
URL: https://github.com/apache/flink/pull/11630#discussion_r403464081
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -49,7 +54,4 @@ kubectl wait --for=condition=complete job/flink-job-cluster
--timeout=1h
kubectl cp `kubectl get pods | awk '/task-manager/ {print
$1}'`:/cache/${OUTPUT_FILE} ${OUTPUT_VOLUME}/${OUTPUT_FILE}
check_result_hash "WordCount" ${OUTPUT_VOLUME}/${OUTPUT_FILE} "${RESULT_HASH}"
-
-if [ $? != 0 ];then
- debug_copy_and_show_logs
-fi
+SUCCEEDED=$?
Review comment:
True. You could register `on_exit debug_and_show_logs` before sourcing
`common_kubernetes.sh`.
But I'm fine with your solution. I just wanted to mention it so that you
know it exists :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
