twalthr commented on a change in pull request #11290: [FLINK-16379][table]
Introduce fromValues in TableEnvironment
URL: https://github.com/apache/flink/pull/11290#discussion_r404070247
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java
##########
@@ -158,6 +158,27 @@ else if (Number.class.isAssignableFrom(valueClass) &&
clazz == BigDecimal.class)
return Optional.ofNullable((T) convertedValue);
}
+ private <T> Object convertNumeric(Class<T> toClazz) {
+ BigDecimal bigDecimal = new BigDecimal(String.valueOf(value));
+ if (toClazz == Integer.class) {
Review comment:
nit: order by byte length to be in sync with other case distinctions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
