AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404299271
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -845,21 +845,19 @@ public ExecutorService getAsyncOperationsThreadPool() {
private void notifyCheckpointComplete(long checkpointId) {
try {
- boolean success = actionExecutor.call(() -> {
Review comment:
`actionExecutor` was added during checkpoint lock deprecation to unify
`SourceStreamTask` and `StreamTask`.
Basically, under `StreamTask` it's a no-op operation going through
`StreamTaskActionExecutor.IMMEDIATE`, while `SourceStreamTask` is using
`StreamTaskActionExecutor#SynchronizedStreamTaskActionExecutor`, which acquires
checkpoint lock for all operations.
None of these implementations use mailbox for any task. However, the
`Mailbox` internally uses the `StreamTaskActionExecutor`.
I agree that the naming and the tight integration into the `MailboxExecutor`
makes it hard to understand at first. Luckily, we can get rid of it, once
FLIP-27 is fully implemented and we can get rid of legacy source thread (so in
about 3 years? ;)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
