zhuzhurk commented on a change in pull request #11647: [FLINK-16960][runtime]
Add PipelinedRegion interface
URL: https://github.com/apache/flink/pull/11647#discussion_r404524838
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/topology/Topology.java
##########
@@ -39,4 +39,26 @@
* @return whether the topology contains co-location constraints
*/
boolean containsCoLocationConstraints();
+
+ /**
+ * Returns all pipelined regions in this topology.
+ *
+ * @return Iterable over pipelined regions in this topology
+ */
+ default Iterable<PipelinedRegion<VID, RID, V, R>>
getAllPipelinedRegions() {
Review comment:
I think we can have an `ExecutionPipelinedRegion` class which implements the
`PipelinedRegion` interface.
Similar to `Topology` -> `SchedulingTopology`.
The `SchedulingStrategy` should operate on `ExecutionPipelinedRegion`
instead.
Note that we already have a `LogicalPipelinedRegion` and I think we should
also rework it. Then this method does not need to be default since
`LogicalTopology` can also return logical regions (we already have this method
implementation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services