wuchong commented on issue #11651: [FLINK-16995][table-common] Add new data 
structure interfaces in table-common
URL: https://github.com/apache/flink/pull/11651#issuecomment-610248154
 
 
   Hi @JingsongLi , I would prefer to refactor all of them together, not one by 
one. This will reduce the refactor work and review work. 
   
   > We will have two kind of formats in Flink repo in this time.
   We will have a follow up refactor PR soon. This situation will not last 
long. 
   
   > I am not sure these formats can work in planner 100%.
   This is on purpose to split the interface and refactoring into separete PRs. 
This PR just focuses on the user-facing APIs and Javadocs, to keep align with 
FLIP-95 proposal. So more people who care API can join in the reviewing. The 
following-up PR should focus on making planner 100% work on this new 
structures. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to