zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404696405
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -184,17 +184,18 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
}
@Override
- public Collection<ResultPartition> createResultPartitionWriters(
Review comment:
Yes, your above comments are exactly right.
There were no ordering requirements when this interface was introduced
firstly. Considering the recovery issue of unaligned checkpoint, the ordering
issue was already guaranteed while constructing the collections of
`ResultPartition` via argument `List<ResultPartitionDeploymentDescriptor>`,
done by a separate PR before.
Now even though we return a `HashSet` as a result, it would not impact the
unaligned checkpoint. Because as long as we create the `ResultPartition` in
determined index, it does not matter to access them in any order from the
collection.
I am also fine if you further want to guarantee the order from return type,
for the potential future usages, but I guess that is not the blocker for
current unaligned checkpoint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
