azagrebin commented on a change in pull request #11427: [FLINK-15790][k8s] Make
FlinkKubeClient and its implementations asynchronous
URL: https://github.com/apache/flink/pull/11427#discussion_r405390126
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesTestBase.java
##########
@@ -84,7 +85,10 @@ public void setup() throws Exception {
TestBaseUtils.setEnv(map);
kubeClient = server.getClient().inNamespace(NAMESPACE);
- flinkKubeClient = new Fabric8FlinkKubeClient(flinkConfig,
kubeClient);
+ flinkKubeClient = new Fabric8FlinkKubeClient(
+ flinkConfig,
+ kubeClient,
+ Executors::newDirectExecutorService);
Review comment:
I did not mean to remove `Executors::newDirectExecutorService` in tests,
only to call `get()` in tests of `Fabric8FlinkKubeClientTest` for newly return
futures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
