pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r405585586
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -184,17 +184,18 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
}
@Override
- public Collection<ResultPartition> createResultPartitionWriters(
Review comment:
But current code implicitly assumes the partition indexes when calling
`Collection#toArray` in `Task` class:
```
// produced intermediate result partitions
final ResultPartitionWriter[] resultPartitionWriters =
shuffleEnvironment.createResultPartitionWriters(
taskShuffleContext,
resultPartitionDeploymentDescriptors).toArray(new
ResultPartitionWriter[] {});
```
so I think it indeed should be a `List`, not a `Collection`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
